Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements #107

Open
wants to merge 4 commits into
base: change_backoff_settings
Choose a base branch
from
Open

UI enhancements #107

wants to merge 4 commits into from

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Nov 27, 2024

Fix #17
Fix #38
Fix #93

Also contains (temporarily) a fix for #104 for which review has already been requested

@benoit74 benoit74 self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.19%. Comparing base (7119f72) to head (d802fef).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           change_backoff_settings     #107      +/-   ##
===========================================================
+ Coverage                    43.76%   44.19%   +0.43%     
===========================================================
  Files                           20       20              
  Lines                         1154     1163       +9     
  Branches                       165      168       +3     
===========================================================
+ Hits                           505      514       +9     
  Misses                         637      637              
  Partials                        12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review November 27, 2024 16:41
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that the fix for #93 is the right approach but for now that's enough (albeit fragile). We need feedback on this feature anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants