Fixed title indexing of items with title identical to the item's path #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
undetitulization
branch
from
7ace3fa to
5b30353
Compare
Contributor
|
@benoit74 to confirm it fixes the issue he reported, then we can merge |
Contributor
|
I will merge this PR once the CI is green. It's urgent to move forward with |
mgautierfr
approved these changes
Apr 16, 2025
This is just a warm-up commit in this PR.
... so that a new unit test (coming in the next commit) can be added in a readable form.
The new test case fails because of a bug (#963).
The fix has a side effect that items with empty titles get indexed by their path.
kelson42
force-pushed
the
undetitulization
branch
from
5b30353 to
8d202f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #963