Fix build with ICU 76 #936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to unicode-org/icu@199bc82, ICU 76 no longer adds `icu-uc` by default. This causes linker errors for undefined symbols like `icu_76::UnicodeString::doReplace(...)`, referenced from: `zim::removeAccents(...)` in tools.cpp.o. Meson will automatically flatten the dependencies list as documented at https://mesonbuild.com/Reference-manual_functions.html#build_target
|
Linux CI has an unrelated failure trying to find Windows CI has a related failure as it looks like Maybe a workaround like: dependency('icu-uc', required: host_machine.system() != 'windows', static:static_linkage)or icu_dep = [dependency('icu-i18n', required:xapian_dep.found(), static:static_linkage)]
if build_machine.system() != 'windows'
icu_dep += [dependency('icu-uc', required:xapian_dep.found(), static:static_linkage)]
endif |
|
@cho-m Thank you for your PR. CI was OK a month ago, I will have a look and try to fix them so we can test your PR properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to unicode-org/icu@199bc82, ICU 76 no longer adds
icu-ucby default. This causes linker errors for undefined symbols likeicu_76::UnicodeString::doReplace(...), referenced from:zim::removeAccents(...)in tools.cpp.o.Meson will automatically flatten the dependencies list as documented at https://mesonbuild.com/Reference-manual_functions.html#build_target
There didn't seem to be any usage of
icu_depmethods and only passing it todependencies: [..., icu_dep, ...]. If this changes, then may need to use multiple variables.