Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test files #910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update test files #910

wants to merge 1 commit into from

Conversation

tusharpm
Copy link
Contributor

counterParsing

  • replace macro with global variable

defaultIndexdata

  • replace arithmetic operations with floating point comparison macro

error_in_creator

  • reduce duplication of template test parameters as described in the comment

parseLongPath

  • succinct assertions using tuple value comparisons

@kelson42
Copy link
Contributor

@mgautierfr Can you please review?

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. But the commit message is a little confusing - no dependencies were updated, and the reason for the changes is not clear. To the best of my understanding it is a nice clean-up of test code (which is definitely welcome) but if it additionally resolves some issue it better be stated in the description.

@tusharpm
Copy link
Contributor Author

Thanks for the review @veloman-yunkan. I was working on another change to include icu.wrap in subprojects, however, decided to PR these changes separately. The commit message included both by mistake. I've amended, rebased and force-pushed the changes.
There's no specific issue being resolved in this PR - just code simplification.

@veloman-yunkan
Copy link
Collaborator

@tusharpm I think that the commit message is still somewhat misleading - it creates an impression that something had changed in the API, dependencies, compiler, etc, so the test files had to be updated to keep things working. Please change the commit message to "Some clean-up in test files" and we will merge the PR.

@kelson42 kelson42 modified the milestones: 9.2.3, 9.3.0 Aug 28, 2024
@kelson42 kelson42 removed the request for review from mgautierfr August 30, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants