-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test files #910
base: main
Are you sure you want to change the base?
Update test files #910
Conversation
@mgautierfr Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. But the commit message is a little confusing - no dependencies were updated, and the reason for the changes is not clear. To the best of my understanding it is a nice clean-up of test code (which is definitely welcome) but if it additionally resolves some issue it better be stated in the description.
Thanks for the review @veloman-yunkan. I was working on another change to include |
@tusharpm I think that the commit message is still somewhat misleading - it creates an impression that something had changed in the API, dependencies, compiler, etc, so the test files had to be updated to keep things working. Please change the commit message to "Some clean-up in test files" and we will merge the PR. |
counterParsing
defaultIndexdata
error_in_creator
parseLongPath