Follow up of PR#1029 #1031
Merged
Follow up of PR#1029 #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed compilation failure in cluster and creator unit-tests that rely on the non-public API of libzim.
Detection of corrupted offset of the first blob in a cluster was implemented under the assumption that clusters cannot be empty. The falsehood of that assumption is demonstrated by the existence of the ClusterTest.read_write_no_content unit test.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 56.18% 56.25% +0.07%
==========================================
Files 101 101
Lines 4989 5002 +13
Branches 2170 2177 +7
==========================================
+ Hits 2803 2814 +11
+ Misses 739 738 -1
- Partials 1447 1450 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The test ZIM file invalid.too_small_offset_of_first_blob_in_cluster_4.zim which simulated a corrupted cluster header leading to a cluster with no blobs in it (a case which was decriminalized by the previous commit) now caught a situation where a crash could occur because of an out-of-bound access in a cluster (this can happen due to invalid data in either a cluster header or a dirent). Cluster::getBlobOffset() must be checked at runtime too!
veloman-yunkan
force-pushed
the
follow-up_of_PR1029
branch
from
dcb7202 to
b385e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1029 was merged prematurely and broke the CI. This PR fixes the issues introduces by #1029, but also eliminates a pre-existing loophole for a crash scenario.