Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ENTRYPOINT by CMD in Docker image #30

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Replace ENTRYPOINT by CMD in Docker image #30

merged 2 commits into from
Dec 18, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 18, 2023 •
edited
Loading

Rationale

Fix #28

Changed

  • use CMD instead of ENTRYPOINT in Docker image
  • force Python 3.11 (do not yet use Python 3.12)

@benoit74 benoit74 self-assigned this Dec 18, 2023
@benoit74
Copy link
Collaborator Author

@rgaudin I would be happy to receive feedback on this, but I merge right now to move on, changes will probably be minor if you find some needed.

@benoit74 benoit74 merged commit 7cb1def into main Dec 18, 2023
5 checks passed
@benoit74 benoit74 deleted the fix_docker branch December 18, 2023 07:46
@rgaudin
Copy link
Member

rgaudin commented Dec 18, 2023

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin Awaiting requested review from rgaudin

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image is using an ENTRYPOINT while we expect a CMD for Zimfarm operation
2 participants
@benoit74 @rgaudin