-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libreswan: uci configuration support #19233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fw4 has recently added a new feature where other packages can add additional rules.
https://git.openwrt.org/?p=project/firewall4.git;a=commit;
Adding the rules to fw4 directly has certain advantages.
- the rules are still there after a firewall reload
- you don't have to work with the command handle from the nftables
I have already prepared the strongswan to use this new feature.
https://github.com/openwrt/packages/pull/18559/files
ed98628
to
ad8b48c
Compare
@feckert All comments have been addressed, Pls comment If anything else is there to consider. |
7e09cf6
to
d5afe4c
Compare
It will be difficult to test this in my setup. I am not useing libreswan. I'll have to see if I have time to test it. |
d5afe4c
to
542d886
Compare
542d886
to
6469cf5
Compare
c1a9fbe
to
9a2a88e
Compare
7c2ee11
to
b5bc60f
Compare
b5bc60f
to
2e514f7
Compare
Good stuff! |
2e514f7
to
4984149
Compare
@feckert ping about this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I still don't have a setup for libreswan, but from what I've seen it looks good. I think we can give it a try after you have answered my comments.
4984149
to
e32fe0c
Compare
Now you have to increment the PKG_RELEASE by one. Then we can merge and give the pullrequest a chance. |
Add libreswan UCI configuration and hotplug support Signed-off-by: Jaymin Patel <[email protected]>
e32fe0c
to
52af24f
Compare
Updated. |
Thank you for your patience. |
Maintainer: @lucize @feckert
Run tested: x86-64, aarch64, virtual box, marvell_armada-3720-db
Description:
Add libreswan UCI configuration and hotplug support
packaged uci config (/etc/config/libreswan) file provides examples/details with commented sections.
Continuation from #19079
@feckert