mt76: add kernel version compatibility for timer APIs#1026
Open
graysky2 wants to merge 1 commit intoopenwrt:masterfrom
Open
mt76: add kernel version compatibility for timer APIs#1026graysky2 wants to merge 1 commit intoopenwrt:masterfrom
graysky2 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
46 tasks
Contributor
|
The timer_delete_sync() and container_of() functions will also work in kernel 6.12. |
Author
|
How is the latest commit |
Contributor
|
There is also a function/macro timer_container_of() (since v6.16) Look at lwfinger/rtw88#373 |
Author
|
Thanks for your review! |
namiltd
reviewed
Dec 28, 2025
Add version checks to support both old and new timer APIs across different kernel versions: - Use timer_delete_sync() on kernels >= 6.1, fall back to del_timer_sync() on older kernels. The timer_delete_sync() function was introduced in kernel 6.1 as a replacement for del_timer_sync(). - Use from_timer() for timer callbacks on kernels >= 4.15, fall back to container_of() on older kernels. The from_timer() macro was introduced in kernel 4.15 as part of the timer API modernization. - Use hrtimer_setup() on kernels >= 4.15, fall back to manual hrtimer_init() and function assignment on older kernels. The hrtimer_setup() helper was introduced alongside the timer callback changes in kernel 4.15. - Use timer_container_of() on kernels >= 6.16 and container_of() for older kernels. Since the minimum supported kernel is currently 6.12, there is no need to add container_of() for older kernels. Signed-off-by: John Audia <therealgraysky@proton.me>
Contributor
|
Maybe before someone looks at this PR, create an alternative patch directly in OpenWRT in package/kernel/mt76/patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add version checks to support both old and new timer APIs across different kernel versions: