Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-nlbwmon: the default of database_compress is 1, match that behaviour in UI. #7560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 11, 2025

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: x86_64 VM with OpenWrt 24.10.0-rc5 (r28304-6dacba30a7)
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
    Screenshot_2025-01-11_16-29-38
  • ( Optional ) Closes luci-app-nlbwmon: "Compress database" does not match the behaviour if "option database_compress" is missing #5243
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: Right after fresh installation of luci-app-nlbwmon, the /etc/config/nlbwmon has
	# Whether to gzip compress archive databases. Compressing the database
	#option database_compress 1

With this change, the no option situation is matched in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant