luci-app-filemanager: Editing hex files improvements #7521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 1, 2025
|
Please summarise the changes this PR adds, into the commit messages also. You've closed two previous PRs so that info is lost. This change does not only do "Now the 'Toggle ASCII' button is disabled if the file is hex." |
- Now it uses fs.read_direct() to retrieve the file content - Now it opens non-text files in hex Editor by default - Now the 'Toggle to ASCII mode' button is disabled in hex Editor if the file is non-text. Signed-off-by: Dmitry R <[email protected]>
rdmitry0911
force-pushed
the
luci-app-filemanager
branch
from
0dbd7d6 to
dd6e49a
Compare
I commented all the changes in the commit message. |
|
Merged, thanks @rdmitry0911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileNow the 'Toggle ASCII' button is disabled if the file is hex.