Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-base: allow sort value to be reassigned #7520

Merged
merged 1 commit into from
Jan 1, 2025
Merged

luci-base: allow sort value to be reassigned #7520

merged 1 commit into from
Jan 1, 2025

Conversation

dannil
Copy link
Contributor

@dannil dannil commented Jan 1, 2025 •
edited
Loading

Commit 234e131 changed the "val" variable to be a constant, but it's value is reassigned later. Change the variable to be declared with let instead so it can be reassigned.

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile N/A
  • Tested on: (x86/64, 24.10.0-rc4, Firefox) ✅
  • ( Preferred ) Mention: @ the original code author for feedback @systemcrash
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. luci-base: Sorting of GridSection does not work #7519
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

Before: sorting on zone forwardings fails (applies to all GridSections)
Screenshot_18

After: sorting on zone forwardings works correctly (applies to all GridSections)
Screenshot_19
Screenshot_20

@dannil
luci-base: allow sort value to be reassigned
679eee2 
Commit 234e131 changed the "val"
variable to be a constant, but it's value is reassigned later. Change
the variable to be declared with let instead so it can be reassigned.

Signed-off-by: Daniel Nilsson <[email protected]>
@dannil dannil mentioned this pull request Jan 1, 2025
Closed
1 task
@systemcrash systemcrash merged commit f5c1806 into openwrt:master Jan 1, 2025
5 checks passed
@systemcrash
Copy link
Contributor

Gratefully accepted!

@dannil dannil deleted the form-es6-fix branch January 1, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannil @systemcrash