Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-base: follow-up fix for ES6 changes #7503

Merged
merged 1 commit into from
Dec 25, 2024
Merged

luci-base: follow-up fix for ES6 changes #7503

merged 1 commit into from
Dec 25, 2024

Conversation

1715173329
Copy link
Member

follow-up for c2fc96c

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (aarch64, HEAD, chrome) ✅
  • ( Preferred ) Mention: @systemcrash
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (Fixes Uncaught TypeError: Cannot read properties of undefined (reading 'hasOwnProperty'))

@1715173329
luci-base: follow-up fix for ES6 changes
e964352 
follow-up for c2fc96c

Signed-off-by: Tianling Shen <[email protected]>
@1715173329 1715173329 mentioned this pull request Dec 25, 2024
Closed
9 tasks
@systemcrash systemcrash merged commit 2da1efb into openwrt:master Dec 25, 2024
5 checks passed
@systemcrash
Copy link
Contributor

Gratefully accepted. Thanks @1715173329 !

@1715173329 1715173329 deleted the es6-lb branch December 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1715173329 @systemcrash