CODEOWNERS with list of maintainers

[stokito]

The second attempt of the #6830 that was closed after a discussion.
My proposition is to add the CODEOWNERS file to help for contributors to quickly find a maintainer (as I did myself today). Even better, for those devs that already have a write access they'll automatically be assigned as reviewers for a PR for the particular app.

The other steps like creating luci-dev team as I described in my comment can be done later. But the CODEOWNERS can start helping us today and save time for contributors. We may add a link to it into the PR template.

It won't change anything in terms of security so the PR is safe to merge.

[Ramon00]

just merge this?

[hnyman]

Not much has changed since #6830 which did not receive approval.
(and like jow noted in that PR, the proposed list already contains quite many ancient users who haven't been active for a while)

[stokito]

I'm not sure why that PR was closed. The discussion turned into enabling an automatic reviewer assignment. To enable this it needs to configure a team. Here I recreated the PR because even without this step this is just a list of github nicknames of maintainers. If some maintainer is not active anymore we can remove it from the list and from the package maintainer field. Anyway if someone creates a PR they'll find same persons and CC them. But we can simplify this step.

[Ramon00]

I guess this is in the catagory "better than nothing". But anyway, somebody needs to make decision, either merge or not. Waiting for the all singing and dancing solution will likely mean nothing will happen.

[systemcrash]

I've read earlier revisions of info on this document and found some things left unexplained. More recent revisions seem much more clear.

https://github.com/github/docs/blob/main/content/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md

But... unless a user mentioned in the CODEOWNERS file has write permissions to this repo, it's nothing more than a glorified reference document (so no behaviour changes will result, at present standards; a good thing). The document needs to be maintained, however. Do you commit to maintaining it?

[stokito]

no problem, please merge

[stokito]

I also added the link to CODEOWNERS to PR template. Maybe it also worth to add a link to issues but we may probably overwhelm maintainers. We better to do a triage ourselves and mention a maintainer if needed.

[stokito]

@systemcrash friendly remind on this

[hnyman]

@stokito
You keep pushing for this, but so far I have seen no green light from any of the core OpenWrt developers who should have a say, neither in this PR or in the other (where there was hesitancy and opposition).

Well, looking for more closely:
Actually Github makes this easy for us: Apparently currently you can't be made as CODEOWNERS list member without write access. This PR with visible error messages shows it quite clearly:

And as there should be no commit access given to that amount of people, this is an automatic no-go.

[stokito]

Some owners don't have access, some have, That only means that some authors will receive a notification on PR but some not. This is still useful even as a simple list of maintainers. The github errors don't affect the process. As a result of the PR it will be easier to find a maintainer to mention and this saves time.

[systemcrash]

So... I don't think having this is bad or causes any undesirable behaviour changes. Githubs documentation on the feature is now much more clear on it. It just requires being kept up to date, something, which I think @stokito seems OK with maintaining?

[stokito]

Yes, I'm fine for maintaining. I can even gradually contact maintainers to confirm if they still are maintaining their apps.