-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Realtime Graphs Respect Bootstrap Dark Mode #6982
Conversation
Looks good! Just pay attention to other PR checks and resolve those. Squash your changes into a single commit and force push. Remember your signed-off-by line in the commit message. |
Thanks, did as requested. |
Almost! Just add subject line to commit, line should start like "themes: ..." |
This feature is to have the realtime graphs dark when using Bootstrap Dark Theme Signed-off-by: james <[email protected]>
Good! Thanks. |
@systemcrash if I make improvements do I make a new pull request? |
@thomasschroeder what do you think of this? I left the border black because imo it looks better |
Looks good to me! But one additional point - it seems like the wireless tab is missing in your original PR: Update: For the Wireless tab at real time graphs it would be And for the WiFi channel analysis: |
thanks, I don't use wireless so my build doesn't have those tabs |
Currently, the realtime graphs, under Status > Realtime Graphs are always white, even in Bootstrap Dark theme.
This change will make the graphs dark in darkmode. I wanted to get some guidance on whether this is the right direction.
I used !important to set the color because I needed to override the JS which is setting the background white directly. I looked at fixing this in the javascript but there doesn't seem to be common variables among the different themes, so this way seemed the simplest.
This is my first PR so please be patient if I have done anything incorrectly.
Example of dark graph.
Currently the graph lines do not show up well, I can work on that if requested.