luci-app-opkg: show disk space consistent with overview #6897
Conversation
stangri
force-pushed
the
master-luci-app-opkg
branch
2 times, most recently
from
e8878f5 to
de3b887
Compare
|
Please submit the change without the entire file reformatted, otherwise it is impossible to see actual changes. |
stangri
force-pushed
the
master-luci-app-opkg
branch
2 times, most recently
from
2ad8ac1 to
6dc4c91
Compare
|
@jow- sorry about that, turns out it was a different editor (subl) I've used to prepare PR which was formatting the file differently. I've noticed there were two occurrences of 4 spaces used instead of the tab in the file, I've replaced those. Let me know if you want it reflected in the commit message. |
stangri
force-pushed
the
master-luci-app-opkg
branch
from
6dc4c91 to
3fb99fd
Compare
applications/luci-app-opkg/htdocs/luci-static/resources/view/opkg.js
Outdated
Show resolved
Hide resolved
stangri
force-pushed
the
master-luci-app-opkg
branch
from
3fb99fd to
60ae987
Compare
|
I did not run test it, but looks nice. However, I am thinking if the percentage number is actually useful at all, as the remaining free space in MiB is the most relevant info at the package installation page (to determine how much can still be installed). I wonder if it might be more useful to drop the percentage number from text (but keep the graph bar), and change the text to be something like "7.2 MiB used of 16 MiB, 8.8 MiB still free" |
This matches the suggestion on the forum as well, to display the available space in MiB better. Let me sleep on it/play with various options and I'll update PR within 72-96 hours. |
* Show Disk space graph consistent with the Status->Overview page * Brought up in https://forum.openwrt.org/t/software-space-is-going-to-full/187112 * Leading whitespaces reformatted by vscode * Localizable disk space progress bar title * Kudos to https://forum.openwrt.org/u/psherman for coming up with final design Signed-off-by: Stan Grishin <[email protected]>
stangri
force-pushed
the
master-luci-app-opkg
branch
from
60ae987 to
c80ca79
Compare
|
It's a small enough change I feel I can merge it with reviews from @hnyman and @systemcrash -- thank you gentlemen for quick responses. @jow-, @McGiverGim thank you for the feedback helping improve this PR! |
luci-app-opkg: show disk space consistent with overview (cherry picked from commit eb40b0b)
I'm attaching screenshot of the change, which is consistent how space is displayed in Status->Overview
