luci-mod-network: let sourcefilter option available for most proto #6864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does “and more” mean everything except dhcp? |
|
I'd prefer an explicit whitelist, maybe we can even reuse |
|
Agreed.
Explicit is far more readable and extensible (esp when new protocols
arrive).
|
|
@systemcrash @jow- |
|
Check jows link. Good example.
… @systemcrash <https://github.com/systemcrash> @jow-
<https://github.com/jow->
all proto bring up by dhcpv6 should use sourcefilter option, so how to
write such a whitelist
|
ptpt52
force-pushed
the
pr-sourcefilter
branch
from
56dc673 to
7232b0e
Compare
|
hmm I prefer use blacklist |
ptpt52
force-pushed
the
pr-sourcefilter
branch
from
7232b0e to
3668d2b
Compare
|
update: sourcefilter option support for listed proto |
ptpt52
force-pushed
the
pr-sourcefilter
branch
from
3668d2b to
26ea3c9
Compare
|
update: also add |
Looks good - could you alpha 0-9a-z sort the list please? |
sourcefilter option should be available for proto like: 'dhcpv6' 'directip' 'ppp' 'pppoe' 'pppoa' 'pptp' 'qmi' 'mbim' 'ncm' '3g' Signed-off-by: Chen Minqiang <[email protected]>
ptpt52
force-pushed
the
pr-sourcefilter
branch
from
26ea3c9 to
6662341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourcefilter option should be available for proto like: ppp
pptp
pppoe
pppoa
ncm
mbim
qmi
...and more