luci-app-usteer: added nslookup of AP name

[Ramon00]

added nslookup of AP name

[Ramon00]

if anybody can test, that would be great

[McGiverGim]

Tested but it seems not to work if I enable to use IPv6 in the config.
I have observed that the Hosts variable contains both, the IPv4 and the IPv6 of the hosts, for example, this are my two APs:

Maybe you can search for the IP at the Hosts variable?

[Ramon00]

I actually did not test IPv6. Seems the issue is that it uses a link local address, which does not appear to resolve with an nslookup. I can manually search the hosthints but well that is kinda inefficients if there is a large list... So hmmm

[McGiverGim]

It's not similar to the search for mac, ip, name, etc. of each device?

[Ramon00]

All the other lookups are just indexed by mac address. Another issue is that all the link local addresses of the other APs are only available on the router (at least not on my setup), while the IPv4 can be made availble elsewhere via dnsmasq. So im not sure how to proceed. I could do the one for IPv4 and the other for IPv6 i suppose

[McGiverGim]

If performance is a problem, maybe you can create a new global variable starting from Hosts and indexing from IP?

[Ramon00]

To be honest I dont know if that is a problem, not in my setup, but not sure how it scales... Anyway I added a search in the hosthints. Give it a try

[McGiverGim]

Give it a try

Working perfectly!! In my case only two APs, and about 15 devices in hearing map, so I can't speak about performance. It works fast in my case.

Maybe some people want to have the MAC too, not only the name. To me is enough like it is now, but only a suggestion.

[McGiverGim]

I suppose in the worst case, if someone complains for performance, exists the possibility to add a check in the hearing tab. When checked, do the translation, if not let the mac alone.

[Ramon00]

about 15 devices in hearing map
Its about the amount of APs times the amount of IP address in the host hints. Anyway, the way it is implemented now is that it only does it one time the page is loaded, not every refresh. So I think it should be fine.

[Ramon00]

@systemcrash Could you do a review of the code and merge if ok?

[systemcrash]

I don't use usteer, but the code largely looks acceptable. @McGiverGim seems to verify its stability.

Performance we can iterate on.

[systemcrash]

So while I'm not a big fan of global variables like var dns_cache = [];, the only other way around it is variable passing. Not a deal breaker. Everything works for you as intended, yes?

[Ramon00]

yes everything works as intended

[systemcrash]

OK - thank you :)

[Ramon00]

@systemcrash And thank you :)