[23.05] backport "luci-app-attendedsysupgrade: add x86 efi/bios case" #6623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbridematt
changed the title
|
The "original" code has a bug, please look here: #6638 Maybe you can cherry-pick the commit. |
|
@mcbridematt If you can implement @McGiverGim suggestion, we can merge this. |
systemcrash
added
fix
x86 is the only target that allows you to install either EFI or BIOS images, thereby add an extra check for that. Signed-off-by: Paul Spooren <[email protected]> (cherry picked from commit d7e905e)
The conditional is wrong. IndexOf returns a number and not true/false, so it does not work. Signed-off-by: Miguel Angel Mulero Martinez <[email protected]> (cherry picked from commit 021c439)
mcbridematt
force-pushed
the
23-05-backport-asu
branch
2 times, most recently
from
77aa27e to
4c55dc7
Compare
|
Thanks for reminding me, I've been busy for the last few months. Cherry picked @McGiverGim's commit on top and tested OK on armsr/armv8. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d7e905e to the 23.05 branch, as armsr targets need this for a functional luci-app-attendedsysupgrade
Tested working on armsr/armv8
(change
DISTRIB_RELEASEin/etc/openwrt_releaseto exactly either23.05orSNAPSHOT, as the asu server may not offer 23.05 builds from a -rc or 23.05-SNAPSHOT build)