-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] Removed support for Python 3.8 #317
Conversation
One thing I couldn't find enough time to handle is
note in the dosctring, but it's not clear what it refers to. It's been a while since 2.6/2.7 got EOL, and it looks like the class has multiple relatively complex usages in the codebase. I can use some help. |
5192e23
to
87309ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulgens thx 🙏.
The build is failing due to a QA check, an unused import.
f0d7656
to
28aa8e1
Compare
@nemesifier Should be okay now |
It fails because of the commit messages now. I feel like the QA is a bit strict, not sure how much value is provided by having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails because of the commit messages now. I feel like the QA is a bit strict, not sure how much value is provided by having
[action]
prefix on every commit but I can update them if needed.
It helps the change log, but don't worry too much about it if you can't get it, we can sort it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ulgens is this ready?
@nemesifier This can be merged as is but I can still use some help for #317 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I couldn't find enough time to handle is
GeoJsonDict
. There isremove this when support for python 2.6/2.7 will be dropped
note in the dosctring, but it's not clear what it refers to. It's been a while since 2.6/2.7 got EOL, and it looks like the class has multiple relatively complex usages in the codebase. I can use some help.
Looks like this comment is incorrect, I guess we can simply update remove the docstring and let this there, it doesn't look harmful and probably is handling a few corner cases.
Okay then, it should be ready to merge now 🙌🏻 |
Thanks @ulgens 🙏 |
I found one small thing I missed in this PR: #319 |
Checklist
Reference to Existing Issue
Closes #314 .
Description of Changes