Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project proposal to move DCQL to OWF #48

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Dec 17, 2024

Still need to add a sponsor, and want to get a review from @auer-martin first.

Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Copy link

@auer-martin auer-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra TimoGlastra marked this pull request as ready for review December 17, 2024 20:53
@lukasjhan
Copy link
Member

Hi @TimoGlastra, Wow your projects looks really great!

@tkuhrt
Copy link
Contributor

tkuhrt commented Dec 18, 2024

@TimoGlastra : Will you be available on January 8, 2025 to represent this proposal?

@TimoGlastra
Copy link
Contributor Author

@TimoGlastra : Will you be available on January 8, 2025 to represent this proposal?

Yes, as long as it doesn't clash with the Wallet Interoperability SIG!

@tkuhrt
Copy link
Contributor

tkuhrt commented Dec 18, 2024

This should be the week of the offset meeting due to the TAC call. The SIG call would follow immediately after. See you on January 8. Have a good holiday period.

Copy link
Contributor

@tkuhrt tkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

@TimoGlastra
Copy link
Contributor Author

This should be the week of the offset meeting due to the TAC call. The SIG call would follow immediately after. See you on January 8. Have a good holiday period.

Perfect, thanks. You too 🎅

@TimoGlastra
Copy link
Contributor Author

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

@tkuhrt
Copy link
Contributor

tkuhrt commented Dec 18, 2024

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

This was related to the project repo, not this PR. Just to be sure we are on the same page.

@TimoGlastra
Copy link
Contributor Author

TimoGlastra commented Dec 20, 2024

Something I'd like input on during the TAC WG or here: I've been chatting with @marsouin and @auer-martin a PEX light library that will be very similar in design as this DCQL library. Should we propose this as a separate lab project? Can it fall under this one and we make it "credential query languages typescript" project (but still two repositories)?

@TimoGlastra
Copy link
Contributor Author

I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.

I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything

This was related to the project repo, not this PR. Just to be sure we are on the same page.

Misunderstood you there, opened an issue: openwallet-foundation-labs/dcql-ts#25

projects/dcql-ts.md Outdated Show resolved Hide resolved
Signed-off-by: Timo Glastra <[email protected]>
@tkuhrt
Copy link
Contributor

tkuhrt commented Dec 20, 2024

Something I'd like input on during the TAC WG or here: I've been chatting with @marsouin and @auer-martin a PEX light library that will be very similar in design as this DCQL library. Should we propose this as a separate lab project? Can it fall under this one and we make it "credential query languages typescript" project (but still two repositories)?

A single lab can have multiple repositories. We typically use some sort of prefix to group the repos. Something like "CQL-repo1" and "CQL-repo2". We would just need to determine the correct prefix, which should be based on the name of the lab.

@auer-martin
Copy link

I'll be looking at the dco and the other issues in the dcql repository over the weekend

@tkuhrt
Copy link
Contributor

tkuhrt commented Jan 8, 2025

APPROVED at the January 8, 2025 meeting

Action: @TimoGlastra to add link to specification to the proposal.

projects/dcql-ts.md Outdated Show resolved Hide resolved
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Contributor Author

Added a link to the specification!

@tkuhrt tkuhrt merged commit 936bdf2 into openwallet-foundation:main Jan 8, 2025
2 checks passed
@tkuhrt tkuhrt added the approved label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants