-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cheqd): cheqd revocationRegistryDefinition resource name #2139
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: DaevMithran <[email protected]>
|
Signed-off-by: DaevMithran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Some notes
packages/cheqd/src/anoncreds/services/CheqdAnonCredsRegistry.ts
Outdated
Show resolved
Hide resolved
packages/cheqd/package.json
Outdated
@@ -26,7 +26,7 @@ | |||
"test": "jest" | |||
}, | |||
"dependencies": { | |||
"@cheqd/sdk": "^2.5.1", | |||
"@cheqd/sdk": "^2.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should properly test this in RN. We have to pin everything to a very specific version or the SDK breaks. Even with the current version it throws an unhandled promise rejection on startup (due to wasm errors) but it somehow still works for resolving.
We haven't had the time to properly look into it, but before we can merge this we should first test it in react native (actually we should pin the version to 2.5.1 for now, instead of using ^2.5.1 until it's fixed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting it! It would be very helpful if you can create an issue on our sdk with context-rich logs or reproduction steps. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimoGlastra after our mainnet upgrade we got some feedback that Cheqd transactions from credo are failing, and you can also see that some of the integration tests are failing in 2.5.1. This must be due to insufficient gas after introducing our fee market module, In our latest sdk we have fixed the default gas fees. We have not made any major dependency changes from 2.5.1 to 2.6.0
Signed-off-by: DaevMithran <[email protected]>
Signed-off-by: DaevMithran <[email protected]>
This PR fixes resource name collisions for revocation registries with different tags.
Creating two revocation registries with same name's will lead to updating the resource. Adding credential definition tag in the resource name will fix this issue