Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes restart without indy pool disconnect #2137

Conversation

GHkrishna
Copy link
Contributor

What

Fixes: Unable to reinitialize agent once shut down #2135

Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: c9d20a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sairanjit
Copy link
Contributor

@GHkrishna When is the pool close method called?

@GHkrishna
Copy link
Contributor Author

GHkrishna commented Dec 29, 2024

@GHkrishna When is the pool close method called?

Pool close from the IndyVDR is not initiated for now as it needs to be fixed first.

For now, we are just resetting the pool variable, as if the pool was never initialized. But since we know we did, we'll reuse the same pool.

@sairanjit
Copy link
Contributor

Yes @GHkrishna We have to close the pool. We can do that by subscribing to the stop$ subject.

@GHkrishna
Copy link
Contributor Author

@TimoGlastra need your help with the failing E2E Tests. Ig our change shouldn't affect it.

@TimoGlastra TimoGlastra requested a review from a team as a code owner January 8, 2025 12:23
@TimoGlastra TimoGlastra merged commit ec525cf into openwallet-foundation:main Jan 8, 2025
11 of 13 checks passed
@GHkrishna GHkrishna deleted the fix/agent-restart-indyVRD-pool-issue branch January 8, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants