Skip to content

fix: allow underscores in domain name segments #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: allow underscores in domain name segments #421

merged 1 commit into from
Feb 27, 2025

Conversation

favoyang
Copy link
Member

Update domain name validation regex to permit underscores in domain segments, expanding support for package naming conventions. Fixed #420

@favoyang
fix: allow underscores in domain name segments
f1e6521 
Update domain name validation regex to permit underscores in domain segments, expanding support for package naming conventions. Fixed #420
@favoyang favoyang merged commit 6fbc3db into master Feb 27, 2025
5 checks passed
@favoyang favoyang deleted the domain-name-fix branch February 27, 2025 16:47
github-actions bot pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 4.5.1 [skip ci]
d90c1d0 
## [4.5.1](4.5.0...4.5.1) (2025-02-27)

### Bug Fixes

* allow underscores in domain name segments ([#421](#421)) ([6fbc3db](6fbc3db)), closes [#420](#420)
@favoyang favoyang mentioned this pull request Feb 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't install the package 'org.nuget.sqlitepclraw.bundle_e_sqlite3' from custom registry. But was able earlier (previous version of openupm-cli?)
1 participant
@favoyang