refacor: split upm config type #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 3, 2024 09:56
This reverts commit b35ef4e.
Change into "put registry auth" service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
UPMConfigtype represents the file content of aupmconfig.tomlfile. Since the datatype has the same structure as the file, the whole application has to be somewhat designed around it, which can be cumbersome.This change splits this type into two, one (
UpmConfigContent) still represents the file, butUpmConfignow only holds the auth information in a easier to access format. This makes it`s usage simpler in the service layer of the app. To compensate a translation or import/export logic was added to the io layer for converting between the two representations.