UCT/VERBS/RC: Fix the macro that is supposed fill desc within uct rc. #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
previously approved these changes
Sep 18, 2024
yosefe
previously approved these changes
Sep 19, 2024
tvegas1
reviewed
Sep 19, 2024
toorajtaraz
changed the title
toorajtaraz
force-pushed
the
topic/fix_macro_in_uct_rc_verbs
branch
from
de202eb
to
7ae430b
Compare
tvegas1
approved these changes
Oct 4, 2024
brminich
approved these changes
Oct 4, 2024
|
@toorajtaraz can you please squash the commits? |
… verbs. UCT/VERBS/RC: wrapping _desc in ()
toorajtaraz
force-pushed
the
topic/fix_macro_in_uct_rc_verbs
branch
from
7ae430b
to
5c09579
Compare
yosefe
approved these changes
Oct 6, 2024
|
@toorajtaraz have you or your organization signed the CLA https://openucx.org/license/? |
|
@yosefe I will sign it today! Is there a way to submit it online or does it have to be mailed to the address mentioned in the CLA? |
Hi, unfortunately there is no online form at this time, so kindly send it to the email address. Thank you! |
|
Hi, Thank you! I just emailed the signed CLA. @yosefe |
|
@yosefe Hey, I wanted to let you know that a few days ago my ucf consortium account was created. Thanks! |
|
approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the macro that is supposed fill desc withing uct rc.
What
This change fixes a typo in the implementation of
UCT_RC_VERBS_FILL_DESC_WR.Why
The assignment to
sge->addrincorrectly usesdescinstead of_desc. While this won't cause a compilation error if the actual variable passed to the macro is nameddesc, the macro should consistently use_descthroughout its implementation.How
Since this is just a typo, the only change required was adding an underscore (
_)!