AZP: Retry git clone #10158
Merged
AZP: Retry git clone #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexey-Rivkin
force-pushed
the
topic/rm_manual_git_clone
branch
5 times, most recently
from
c7f4e0d
to
06bcc58
Compare
Alexey-Rivkin
changed the title
Alexey-Rivkin
force-pushed
the
topic/rm_manual_git_clone
branch
from
06bcc58
to
819362f
Compare
dpressle
suggested changes
Sep 22, 2024
| @@ -247,3 +247,23 @@ get_arch() { | |||
| echo "$arch" | |||
| fi | |||
| } | |||
|
|
|||
| git_clone_with_retry() { | |||
There was a problem hiding this comment.
fix indentation (see other functions in this file)
There was a problem hiding this comment.
Changed indentation to match the existing code style.
There was a problem hiding this comment.
existing indentation uses 4 spaces you use tabs, its not the same
There was a problem hiding this comment.
Good catch! Fixed.
yosefe
reviewed
Sep 25, 2024
buildlib/az-helpers.sh
Outdated
| local branch="$1" | ||
| local target_dir="$2" | ||
| local max_attempts=5 | ||
| local repo_url="https://github.com/openucx/ucx.git" |
There was a problem hiding this comment.
can we take it from some azure env var?
There was a problem hiding this comment.
Done, thank you for the great idea!
buildlib/az-helpers.sh
Outdated
|
|
||
| for attempt in $(seq 1 $max_attempts); do | ||
| echo "Attempt $attempt of $max_attempts: Cloning UCX (branch: $branch)" | ||
| if git clone --depth 1 -b "$branch" "$repo_url" "$target_dir"; then |
There was a problem hiding this comment.
maybe pass depth as a parameter?
yosefe
approved these changes
Sep 26, 2024
|
@Alexey-Rivkin pls squash |
dpressle
approved these changes
Sep 29, 2024
Alexey-Rivkin
force-pushed
the
topic/rm_manual_git_clone
branch
from
f665c89
to
248a2a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Retry 'git clone' command in case of a failure.
Why ?
Sometimes we get a git clone error:
Switching to the built-in Azure function will prevent such failures using the retry logic.