UCT/API: Add new MD resource query API #10154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankochin
reviewed
Sep 18, 2024
tvegas1
force-pushed
the
md_resource_query_v2
branch
from
366b3ed
to
1e716b3
Compare
brminich
reviewed
Sep 18, 2024
brminich
previously approved these changes
Sep 18, 2024
ivankochin
previously approved these changes
Sep 18, 2024
rakhmets
reviewed
Sep 19, 2024
rakhmets
reviewed
Sep 19, 2024
rakhmets
reviewed
Sep 19, 2024
rakhmets
approved these changes
Sep 20, 2024
rakhmets
reviewed
Sep 20, 2024
| /** | ||
| * Main resource descriptor | ||
| */ | ||
| uct_tl_resource_desc_t desc; |
There was a problem hiding this comment.
Sorry, I noticed the issue only after I started to review the implementation.
V2 API shouldn't depend on V1 API. If the new structure has to replace the old one, then it is better to write the code without using the old API. Except for the old interface, which uses this structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce UCT MD transport resource descriptor query v2. Relates to #10141.
Why ?
More parameters need to be queried and UCT ABI cannot change.
How ?
Add all mandatory fields as parameters, use new
paramsfor future parameter (in and out).