CI: improve test jenkins error reporting #10145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-shalev
changed the title
yosefe
reviewed
Sep 11, 2024
contrib/test_jenkins.sh
Outdated
| @@ -1161,11 +1161,26 @@ then | |||
| set_ucx_common_test_env | |||
|
|
|||
| if [[ "$PROTO_ENABLE" == "no" ]]; then | |||
| run_test_proto_disable | |||
| run_test_proto_disable || { | |||
There was a problem hiding this comment.
we can see that it's address sanitizer or proto_disable from the test step description in CI, why need also this?
There was a problem hiding this comment.
Because if you want to debug this kind of scenario (happened to me recently), you need to go to the test_jenkins.sh script and find the exact flag (for example: "ASAN_CHECK=yes") to reproduce it with.
By adding this error log, you can just copy-paste and reproduce it.
michal-shalev
force-pushed
the
ci-improve-test-jenkins-error-reporting
branch
from
4a4706f
to
86215e9
Compare
michal-shalev
force-pushed
the
ci-improve-test-jenkins-error-reporting
branch
from
86215e9
to
d8b8b97
Compare
michal-shalev
force-pushed
the
ci-improve-test-jenkins-error-reporting
branch
from
8fcfcd1
to
4e60809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improves error reporting in
contrib/test_jenkins.shto indicate what happened in the Azure DevOps CI pipeline, and how to reproduce it.Why?
Currently, there is no specific
contrib/test_jenkins.shfailure message. This change helps to quickly identify which test failed, improving debugging efficiency, without scrolling through the logs.How?
Modifies the script to add a failure message at the end, making the cause of the failure and reproduction info immediately clear in the CI logs.
Before