GTEST: reduce stack usage in tests #10131
Open
+135
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-shalev
changed the title
ivankochin
previously approved these changes
Sep 18, 2024
9 tasks
michal-shalev
force-pushed
the
reduce-stack-usage-in-tests
branch
from
5574ee9
to
0e978f3
Compare
| @@ -353,6 +353,39 @@ void test_thread::mem_event(ucm_event_type_t event_type, ucm_event_t *event) | |||
| pthread_mutex_unlock(&m_stats_lock); | |||
| } | |||
|
|
|||
| static void* perform_mmap(size_t size, char fill_value) { | |||
There was a problem hiding this comment.
Suggested change
| static void* perform_mmap(size_t size, char fill_value) { | |
| static void *perform_mmap(size_t size, char fill_value) { |
|
|
||
| typedef ucs_status_t (*ucp_dispatch_func_t)(ucx_perf_context_t *perf); | ||
|
|
||
| static ucp_dispatch_func_t dispatchers[] = { |
There was a problem hiding this comment.
IMO better use std::vector here
| @@ -301,7 +301,7 @@ class test_thread { | |||
| private: | |||
| typedef std::pair<void*, void*> range; | |||
|
|
|||
| bool is_ptr_in_range(void *ptr, size_t size, const std::vector<range> &ranges) { | |||
| bool __attribute__((noinline)) is_ptr_in_range(void *ptr, size_t size, const std::vector<range> &ranges) { | |||
There was a problem hiding this comment.
can use UCS_F_NOINLINE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR reduces stack memory usage by converting stack allocations to heap in various UCX tests.
Why?
Customers with limited stack sizes have recently experienced stack overflow issues when running UCX.
The goal is to ensure that the entire UCX runs within a defined stack size threshold. By reducing the stack frame size in tests, this change helps in testing the runtime stack usage, ensuring that it starts within the threshold.
How?
This PR reduces stack usage by deferring complex logic to separate helper functions, minimizing the stack frame size during test execution.