Change path max stack allocation to heap

src/tools/vfs/vfs_main.c

@@ -10,7 +10,9 @@
 
 #include "vfs_daemon.h"
 
+#include <ucs/sys/string.h>
 #include <ucs/debug/log_def.h>
+#include <ucs/debug/memtrack_int.h>
 #include <sys/wait.h>
 #include <limits.h>
 #include <stdlib.h>
@@ -151,10 +153,17 @@ static const char *vfs_get_process_name(int pid, char *buf, size_t max_length)
 
 int vfs_mount(int pid)
 {
- char mountpoint[PATH_MAX];
  char mountopts[1024];
  char name[NAME_MAX];
+ char *mountpoint;
  int fuse_fd, ret;
+ ucs_status_t status;
+
+ status = ucs_string_alloc_path_buffer(&mountpoint, "mountpoint");
+ if (status != UCS_OK) {
+ ret = -ENOMEM;
+ goto out;
+ }
 
  /* Add common mount options:
  * - File system name (source) : process name and pid
@@ -168,58 +177,75 @@ int vfs_mount(int pid)
  vfs_get_process_name(pid, name, sizeof(name)),
  (strlen(g_opts.mount_opts) > 0) ? "," : "", g_opts.mount_opts);
  if (ret >= sizeof(mountopts)) {
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto out_free_mountpoint;
  }
 
  /* Create the mount point directory, and ignore "already exists" error */
- vfs_get_mountpoint(pid, mountpoint, sizeof(mountpoint));
+ vfs_get_mountpoint(pid, mountpoint, PATH_MAX);
  ret = mkdir(mountpoint, S_IRWXU);
  if ((ret < 0) && (errno != EEXIST)) {
  ret = -errno;
  vfs_error("failed to create directory '%s': %m", mountpoint);
- return ret;
+ goto out_free_mountpoint;
  }
 
  /* Mount a new FUSE filesystem in the mount point directory */
  vfs_log("mounting directory '%s' with options '%s'", mountpoint, mountopts);
  fuse_fd = fuse_open_channel(mountpoint, mountopts);
  if (fuse_fd < 0) {
+ ret = fuse_fd;
  vfs_error("fuse_open_channel(%s,opts=%s) failed: %m", mountpoint,
  mountopts);
- return fuse_fd;
+ goto out_free_mountpoint;
  }
 
  vfs_log("mounted directory '%s' with fd %d", mountpoint, fuse_fd);
- return fuse_fd;
+ ret = fuse_fd;
+
+out_free_mountpoint:
+ ucs_free(mountpoint);
+out:
+ return ret;
 }
 
 int vfs_unmount(int pid)
 {
- char mountpoint[PATH_MAX];
+ char *mountpoint;
  char *argv[5];
  int ret;
+ ucs_status_t status;
+
+ status = ucs_string_alloc_path_buffer(&mountpoint, "mountpoint");
+ if (status != UCS_OK) {
+ ret = -ENOMEM;
+ goto out;
+ }
 
  /* Unmount FUSE file system */
- vfs_get_mountpoint(pid, mountpoint, sizeof(mountpoint));
+ vfs_get_mountpoint(pid, mountpoint, PATH_MAX);
  argv[0] = "-u";
  argv[1] = "-z";
  argv[2] = "--";
  argv[3] = mountpoint;
  argv[4] = NULL;
  ret = vfs_run_fusermount(argv);
  if (ret < 0) {
- return ret;
+ goto out_free_mountpoint;
  }
 
  /* Remove mount point directory */
  vfs_log("removing directory '%s'", mountpoint);
  ret = rmdir(mountpoint);
  if (ret < 0) {
  vfs_error("failed to remove directory '%s': %m", mountpoint);
- return ret;
+ goto out_free_mountpoint;
  }
 
- return 0;
+out_free_mountpoint:
+ ucs_free(mountpoint);
+out:
+ return ret;
 }
 
 static int vfs_unlink_socket(int silent_notexist)

src/ucp/proto/proto_debug.c

@@ -984,24 +984,30 @@ ucp_proto_select_write_info(ucp_worker_h worker,
  ucp_proto_query_attr_t proto_attr;
  size_t range_start, range_end;
  ucs_string_buffer_t dot_strb;
- char dir_path[PATH_MAX];
+ ucs_status_t status;
+ char *dir_path;
  FILE *fp;
  int ret;
 
+ status = ucs_string_alloc_path_buffer(&dir_path, "dir_path");
+ if (status != UCS_OK) {
+ goto out;
+ }
+
  ucp_proto_select_param_dump(worker, ep_cfg_index, rkey_cfg_index,
  select_param, ucp_operation_names, &ep_cfg_strb,
  &sel_param_strb);
  if (!ucp_proto_debug_is_info_enabled(
  worker->context, ucs_string_buffer_cstr(&sel_param_strb))) {
- return;
+ goto out_free_dir_path;
  }
 
  ucs_fill_filename_template(worker->context->config.ext.proto_info_dir,
- dir_path, sizeof(dir_path));
+ dir_path, PATH_MAX);
  ret = mkdir(dir_path, S_IRWXU | S_IRGRP | S_IXGRP);
  if ((ret != 0) && (errno != EEXIST)) {
  ucs_debug("failed to create directory %s: %m", dir_path);
- return;
+ goto out_free_dir_path;
  }
 
  ucs_string_buffer_translate(&ep_cfg_strb, ucp_proto_debug_fix_filename);
@@ -1040,6 +1046,11 @@ ucp_proto_select_write_info(ucp_worker_h worker,
  fclose(fp);
 
  } while (range_end != SIZE_MAX);
+
+out_free_dir_path:
+ ucs_free(dir_path);
+out:
+ return;
 }
 
 void ucp_proto_select_elem_trace(ucp_worker_h worker,

src/ucs/config/parser.c

@@ -1614,15 +1614,21 @@ void ucs_config_parse_config_file(const char *dir_path, const char *file_name,
  .section_info = {.name = "",
  .skip = 0}
  };
- char file_path[MAXPATHLEN];
+ char *file_path;
  int parse_result;
  FILE* file;
+ ucs_status_t status;
+
+ status = ucs_string_alloc_path_buffer(&file_path, "file_path");
+ if (status != UCS_OK) {
+ goto out;
+ }
 
  ucs_snprintf_safe(file_path, MAXPATHLEN, "%s/%s", dir_path, file_name);
  file = fopen(file_path, "r");
  if (file == NULL) {
  ucs_debug("failed to open config file %s: %m", file_path);
- return;
+ goto out_free_file_path;
  }
 
  parse_result = ini_parse_file(file, ucs_config_parse_config_file_line,
@@ -1633,6 +1639,11 @@ void ucs_config_parse_config_file(const char *dir_path, const char *file_name,
 
  ucs_debug("parsed config file %s", file_path);
  fclose(file);
+
+out_free_file_path:
+ ucs_free(file_path);
+out:
+ return;
 }
 
 static ucs_status_t
@@ -1750,8 +1761,14 @@ static ucs_status_t ucs_config_parser_get_sub_prefix(const char *env_prefix,
 
 void ucs_config_parse_config_files()
 {
+ char *path;
  const char *path_p;
- char path[PATH_MAX];
+ ucs_status_t status;
+
+ status = ucs_string_alloc_path_buffer(&path, "path");
+ if (status != UCS_OK) {
+ goto out;
+ }
 
  /* System-wide configuration file */
  ucs_config_parse_config_file(UCX_CONFIG_DIR, UCX_CONFIG_FILE_NAME, 1);
@@ -1778,6 +1795,11 @@ void ucs_config_parse_config_files()
 
  /* Current working dir */
  ucs_config_parse_config_file(".", UCX_CONFIG_FILE_NAME, 1);
+
+out_free_path:
+ ucs_free(path);
+out:
+ return;
 }
 
 ucs_status_t

src/ucs/debug/log.c

@@ -145,15 +145,27 @@ static void ucs_log_get_file_name(char *log_file_name, size_t max, int idx)
 
 static void ucs_log_file_rotate()
 {
- char old_log_file_name[PATH_MAX];
- char new_log_file_name[PATH_MAX];
+ char *old_log_file_name, *new_log_file_name;
  int idx, ret;
+ ucs_status_t status;
+
+ status = ucs_string_alloc_path_buffer(&old_log_file_name,
+ "old_log_file_name");
+ if (status != UCS_OK) {
+ goto out;
+ }
+
+ status = ucs_string_alloc_path_buffer(&new_log_file_name,
+ "new_log_file_name");
+ if (status != UCS_OK) {
+ goto out_free_old_log_file_name;
+ }
 
  if (ucs_log_file_last_idx == ucs_global_opts.log_file_rotate) {
  /* remove the last file and log rotation from the
  * `log_file_rotate - 1` file */
  ucs_log_get_file_name(old_log_file_name,
- sizeof(old_log_file_name),
+ PATH_MAX,
  ucs_log_file_last_idx);
  unlink(old_log_file_name);
  } else {
@@ -164,9 +176,9 @@ static void ucs_log_file_rotate()
 
  for (idx = ucs_log_file_last_idx - 1; idx >= 0; --idx) {
  ucs_log_get_file_name(old_log_file_name,
- sizeof(old_log_file_name), idx);
+ PATH_MAX, idx);
  ucs_log_get_file_name(new_log_file_name,
- sizeof(new_log_file_name), idx + 1);
+ PATH_MAX, idx + 1);
 
  if (access(old_log_file_name, W_OK) != 0) {
  ucs_fatal("unable to write to %s", old_log_file_name);
@@ -188,6 +200,13 @@ static void ucs_log_file_rotate()
  ucs_fatal("unable to write to %s", new_log_file_name);
  }
  }
+
+out_free_new_log_file_name:
+ ucs_free(new_log_file_name);
+out_free_old_log_file_name:
+ ucs_free(old_log_file_name);
+out:
+ return;
 }
 
 static void ucs_log_handle_file_max_size(int log_entry_len)

src/ucs/debug/memtrack.c

@@ -433,10 +433,10 @@ void ucs_memtrack_init()
  return;
  }
 
+ ucs_memtrack_vfs_init();
+
  ucs_debug("memtrack enabled");
  ucs_memtrack_context.enabled = 1;
-
- ucs_memtrack_vfs_init();
 }
 
 void ucs_memtrack_cleanup()
@@ -447,12 +447,11 @@ void ucs_memtrack_cleanup()
  return;
  }
 
- ucs_vfs_obj_remove(&ucs_memtrack_context);
-
  ucs_memtrack_generate_report();
 
- /* disable before releasing the stats node */
+ /* disable before releasing the vfs object and the stats node */
  ucs_memtrack_context.enabled = 0;
+ ucs_vfs_obj_remove(&ucs_memtrack_context);
  UCS_STATS_NODE_FREE(ucs_memtrack_context.stats);
 
  /* cleanup entries */

src/ucs/memory/numa.c

@@ -125,16 +125,25 @@ ucs_numa_node_t ucs_numa_node_of_cpu(int cpu)
 {
  /* Used for caching to improve performance */
  static ucs_numa_node_t cpu_numa_node[__CPU_SETSIZE] = {0};
+ char *core_dir_path;
  ucs_numa_node_t node;
- char core_dir_path[PATH_MAX];
+ ucs_status_t status;
 
  ucs_assert(cpu < __CPU_SETSIZE);
 
  if (cpu_numa_node[cpu] == 0) {
+ status = ucs_string_alloc_path_buffer(&core_dir_path, "core_dir_path");
+ if (status != UCS_OK) {
+ return UCS_NUMA_NODE_UNDEFINED;
+ }
+
  ucs_snprintf_safe(core_dir_path, PATH_MAX, UCS_NUMA_CORE_DIR_PATH, cpu);
- node = ucs_numa_get_max_dirent(core_dir_path, "node",
- ucs_numa_num_configured_nodes(),
- UCS_NUMA_NODE_DEFAULT);
+ node = ucs_numa_get_max_dirent(core_dir_path, "node",
+ ucs_numa_num_configured_nodes(),
+ UCS_NUMA_NODE_DEFAULT);
+
+ ucs_free(core_dir_path);
+
  cpu_numa_node[cpu] = node + 1;
  }