fix unannotated fall-through between switch labels in utils/ucc_coll_utils.h #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
Sergei-Lebedev
approved these changes
Jun 11, 2024
|
@bunnypak What is your affiliation? have you or your institution signed CLA? |
https://github.com/openucx/ucc?tab=readme-ov-file#contributing |
Meta. Personally no. Not sure about my institution. |
janjust
approved these changes
Jan 29, 2025
|
All commit name need to comply to this ucc/.github/workflows/codestyle.yaml Line 39 in 06e0d2b Please, edit the commit name so we can merge it, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fix unannotated fall-through between switch labels in
utils/ucc_coll_utils.hWhy ?
When building on x86_64 Linux and clang 15,