Introduce builder for RealtimeTestEnvironment #6043
+443
−361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
technical debt
RealTimeUpdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6043 +/- ##
==========================================
Coverage 69.78% 69.78%
Complexity 17356 17356
==========================================
Files 1962 1962
Lines 74359 74359
Branches 7624 7624
==========================================
+ Hits 51892 51893 +1
+ Misses 19823 19821 -2
- Partials 2644 2645 +1 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
requested review from
t2gran and
habrahamsson-skanetrafiken
habrahamsson-skanetrafiken
requested changes
Sep 6, 2024
...java/org/opentripplanner/updater/trip/moduletests/cancellation/CancellationDeletionTest.java
Outdated
Show resolved
Hide resolved
...java/org/opentripplanner/updater/trip/moduletests/cancellation/CancellationDeletionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/DelayedTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| var tripId = env.trip2.getId().getId(); | ||
| var tripId = TRIP_2_ID; |
There was a problem hiding this comment.
We can probably get rid of this tripId variable now that it doesn't reallly improve readability anymore
There was a problem hiding this comment.
I reworked the handling of the IDs here: c97d90a
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/SkippedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opentripplanner/updater/trip/moduletests/delay/SkippedTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Henrik Abrahamsson <[email protected]>
|
I have now extracted builders not only for the environment but also for the trips that are in it. |
habrahamsson-skanetrafiken
requested changes
Sep 11, 2024
src/test/java/org/opentripplanner/updater/trip/RealtimeTripInput.java
Outdated
Show resolved
Hide resolved
habrahamsson-skanetrafiken
previously approved these changes
Sep 11, 2024
habrahamsson-skanetrafiken
approved these changes
Sep 12, 2024
leonardehrenfried
requested review from
jtorin
and removed request for
t2gran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a previous PR we said that we want to be able to configure the
RealtimeTestEnvironmentinstances and only add those trips that we need. This PR refactors the environment and adds a builder that allows you do to exactly.This is made possible by extracting all constants into a separate class that is used throughout the test code.
Issue
#4816
Unit tests
This is just tests.