Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cn-cbor] upgrade and track master branch #64

Merged
merged 3 commits into from
Apr 10, 2020
Merged

[cn-cbor] upgrade and track master branch #64

merged 3 commits into from
Apr 10, 2020

Conversation

gocarlos
Copy link
Contributor

@gocarlos gocarlos commented Apr 8, 2020

closes #63

@jwhui jwhui requested a review from wgtdkp April 9, 2020 18:01
wgtdkp
wgtdkp approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@wgtdkp wgtdkp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gocarlos ! LGTM 👍

By the way, I saw you contribution to the cn-cbor project to make it work with modern CMake. Do you think we still need the cn-cbor wrapper CMakeList file here?

@wgtdkp wgtdkp requested a review from jwhui April 10, 2020 03:12
@jwhui jwhui added the enhancement New feature or request label Apr 10, 2020
@jwhui jwhui changed the title chore: upgrade cn-cbor [cn-cbor] upgrade and track master branch Apr 10, 2020
@jwhui jwhui merged commit 243aeb5 into openthread:master Apr 10, 2020
@gocarlos
Copy link
Contributor Author

Thanks @gocarlos ! LGTM 👍

By the way, I saw you contribution to the cn-cbor project to make it work with modern CMake. Do you think we still need the cn-cbor wrapper CMakeList file here?

No, i think, we could add cn-cbor directly with add_subdirectory and use the target cn-cbor::cn-cbor

@wgtdkp
Copy link
Member

wgtdkp commented Apr 10, 2020

No, i think, we could add cn-cbor directly with add_subdirectory and use the target cn-cbor::cn-cbor

Thanks, will do the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhui jwhui jwhui approved these changes

@wgtdkp wgtdkp wgtdkp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update cn-cbor
3 participants
@gocarlos @wgtdkp @jwhui