-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tlv] add new tlvs for network diagnostic #266
Closed
Closed
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f0bbe33
[tlv] add new tlvs for network diagnostic
ZhangLe2016 1cc8322
[tlv] add new tlvs for network diagnostic
ZhangLe2016 af7f86f
[tlv] add new tlvs for network diagnostic
ZhangLe2016 8ada05f
[build] output test files to ./tmp (#265)
wgtdkp 57bd5f1
[api] remove the `XpanId` and `PanId` structs (#264)
wgtdkp 6561ae7
[android] cleanup Android sample app (#277)
wgtdkp 397114d
[log] add a new logging region for network diagnostic functionality (…
ZhangLe2016 1913f47
[uri] add DIAG_GET URIs for disgnostic APIs (#267)
ZhangLe2016 62a1b82
[udp-proxy] set local port to dedicated port number(:mm) for udp prox…
ZhangLe2016 384ec58
[thread] make Joiner Provisioning URL independently optional (#285)
wgtdkp af15906
[coap] handle zero coap token length (#286)
wgtdkp e0820a3
[swig] fix the SWIG ignores for java (#287)
wgtdkp 70c626d
[tlv] add new tlvs for network diagnostic
ZhangLe2016 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these also use
>=
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, the TLV will only have content when the queried device has children. If the queried device has no children, the value of TLV is empty, so the length should be 0. If we check the length to be
>=
43, then when the value of TLV is empty, the TLV will be considered invalid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLV
kNetworkDiagVendorSWVersion
is similar. If the device itself does not have a sw version content, then the value of TLV is empty. When the commissioner gets an empty TLV, it should not be judged as invalid tlv. Please correct me~~ Thanks!