-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] update br scan
to allow network interface selection for mDNS binding
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
reviewed
Apr 12, 2024
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
reviewed
Apr 12, 2024
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
reviewed
Apr 15, 2024
Co-authored-by: Kangping <[email protected]>
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
reviewed
Apr 15, 2024
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
mDNS binding. Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface. This change introduces a new option for the CLI command `br scan`. User can now specify a network interface using the syntax `br scan --netif <network interface>. The chosen interface will be used for mDNS binding through socket options.
wgtdkp
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks!!
wgtdkp
reviewed
Apr 22, 2024
jwhui
changed the title
[cli] Update command "br scan" to allow network interface selection for mDNS binding.
[cli] update Apr 22, 2024
br scan
to allow network interface selection for mDNS binding
jwhui
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the OTBR practice application, the BR host will have several interfaces. When users want to discover the border router using mDNS, they will need to choose the specific interface.
This change introduces a new option for the CLI command
br scan
. User can now specify a network interface using the syntax `br scan --netif . The chosen interface will be used for mDNS binding through socket options.