-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(release): use github app token for tag push #709
Merged
project-defiant
merged 1 commit into
dev
from
3384-use-token-from-github-app-to-push-tag
Jul 19, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,14 +34,15 @@ jobs: | |
fetch-depth: 0 | ||
repository: opentargets/gentropy | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
persist-credentials: false | ||
|
||
- name: Python Semantic Release | ||
id: semrelease | ||
# v9.6.0 is required due to the python v3.12 in the newer version of semantic release action which | ||
# breaks the poetry build command. | ||
uses: python-semantic-release/[email protected] | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
github_token: ${{ steps.trigger-token.outputs.token }} | ||
|
||
- name: Publish package to GitHub Release | ||
uses: python-semantic-release/upload-to-gh-release@main | ||
|
@@ -51,7 +52,7 @@ jobs: | |
# requires using GH_APP to authenitcate, otherwise push authorised with | ||
# the GITHUB_TOKEN does not trigger the tag artifact workflow. | ||
# see https://github.com/actions/create-github-app-token | ||
github_token: ${{ steps.trigger-token.outputs.token }} | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
tag: ${{ steps.semrelease.outputs.tag }} | ||
|
||
- name: Store the distribution packages | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this added for security reasons or because it is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/checkout#485 - I have added it not to persist this token, as it's not the default one.