feat: support TerminalWordLink can be override

[wangxiaojuan]

Types

• 🎉 New Features
• 🐛 Bug Fixes
• 📚 Documentation Changes
• 💄 Code Style Changes
• 💄 Style Changes
• 🪚 Refactors
• 🚀 Performance Improvements
• 🏗️ Build System
• ⏱ Tests
• 🧹 Chores
• Other Changes

Background or solution

终端的文字被错误识别成链接，在点击时会触发唤起命令面板

Changelog

feat： TerminalWordLink能够按需开启

Summary by CodeRabbit

• 重构
  • 优化了终端链接处理流程，实现了更及时和一致的链接交互体验。

[wangxiaojuan]

/next

[coderabbitai]

Walkthrough

此次变更在 TerminalLinkManager 类中引入了一个新的私有成员变量 _wrappedTextLinkActivateCallback（类型为 XtermLinkMatcherHandler），用于封装局部链接处理函数。方法 addTerminalWordLinkProvider 随之更新为使用该成员变量。同时，构造函数的调用流程也作出调整，分别调用 addTerminalWordLinkProvider() 与 _registerStandardLinkProviders() 方法，以优化链接提供者的初始化顺序。

Changes

文件路径	更改摘要
packages/terminal-next/.../link-manager.ts	- 添加 _wrappedTextLinkActivateCallback 变量 - 将 addTerminalWordLinkProvider 方法更新为使用新变量 - 修改构造函数，分别调用 addTerminalWordLinkProvider() 与 _registerStandardLinkProviders() 方法

Sequence Diagram(s)

sequenceDiagram
    participant TLM as TerminalLinkManager
    participant LP as TerminalWordLinkProvider
    participant SR as StandardLinkProviders

    TLM->>TLM: 调用构造函数
    TLM->>TLM: 初始化局部链接处理器并包装为 _wrappedTextLinkActivateCallback
    TLM->>LP: 调用 addTerminalWordLinkProvider()
    TLM->>SR: 调用 _registerStandardLinkProviders()

Loading

Possibly related PRs

• feat: add word link provider #4327: 修改 TerminalLinkManager 类，添加 wordLinkProvider 实例并调整构造函数调用顺序，与本次变更存在代码级关联

Suggested labels

🎨 feature

Suggested reviewers

• life2015
• ensorrow
• Ricbet

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 199ac48 and 58473f2.

📒 Files selected for processing (1)

• packages/terminal-next/src/browser/links/link-manager.ts (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: 🚀🚀🚀 Next Version for pull request
• GitHub Check: build (macos-latest, 20.x)
• GitHub Check: build (ubuntu-latest, 20.x)
• GitHub Check: build-windows
• GitHub Check: ubuntu-latest, Node.js 20.x
• GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
• GitHub Check: unittest (ubuntu-latest, 18.x, node)
• GitHub Check: unittest (macos-latest, 18.x, jsdom)
• GitHub Check: unittest (macos-latest, 18.x, node)

🔇 Additional comments (5)

packages/terminal-next/src/browser/links/link-manager.ts (5)

116-116: 添加私有成员变量以增强可扩展性

添加 _wrappedTextLinkActivateCallback 私有成员变量使得链接激活回调可以在类内部重用，并为潜在的覆盖提供支持。这是一个良好的设计决策，使该功能更加灵活。

---

132-132: 正确初始化新成员变量

将本地变量 wrappedTextLinkActivateCallback 的值正确地赋给了类成员变量 _wrappedTextLinkActivateCallback，保持了功能的一致性。

---

142-144: 优化构造函数中的方法调用顺序

将 addTerminalWordLinkProvider() 和 _registerStandardLinkProviders() 方法直接在构造函数中调用，使得初始化流程更加清晰。这样的顺序可以确保先添加 TerminalWordLinkProvider，然后再注册所有标准链接提供者。

---

146-148: 重新定位 processCwd setter

setter 方法的位置调整不会影响功能，只是代码组织结构的变化，提高了代码的可读性。

---

150-157: 使用类成员变量代替本地变量

通过使用类成员变量 _wrappedTextLinkActivateCallback 代替原先的本地变量，使得 TerminalWordLinkProvider 的创建更加灵活。这是此 PR 的核心改动，它允许 TerminalWordLink 功能可以根据特定需求被覆盖。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[opensumi]

🎉 PR Next publish successful!

3.8.3-next-1744177390.0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (58f75a1) to head (58473f2).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4509   +/-   ##
=======================================
  Coverage   53.13%   53.14%           
=======================================
  Files        1665     1665           
  Lines      102648   102663   +15     
  Branches    22216    22228   +12     
=======================================
+ Hits        54543    54560   +17     
+ Misses      40019    40017    -2     
  Partials     8086     8086           

Flag	Coverage Δ
jsdom	48.63% <100.00%> (+<0.01%)	⬆️
node	12.12% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hacke2]

LGTM