Skip to content

fix: system prompt not working#4429

Merged
hacke2 merged 2 commits intov3.8from
fix/system-prompt-not-working
Mar 4, 2025
Merged

fix: system prompt not working#4429
hacke2 merged 2 commits intov3.8from
fix/system-prompt-not-working

Conversation

@Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Mar 4, 2025

Types

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

Changelog

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 4, 2025
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.39%. Comparing base (8248022) to head (d67fac5).
Report is 4 commits behind head on v3.8.

Files with missing lines Patch % Lines
...s/ai-native/src/browser/chat/chat-proxy.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v3.8    #4429      +/-   ##
==========================================
- Coverage   53.39%   53.39%   -0.01%     
==========================================
  Files        1657     1657              
  Lines      102188   102193       +5     
  Branches    22114    22114              
==========================================
  Hits        54563    54563              
- Misses      39616    39622       +6     
+ Partials     8009     8008       -1     
Flag Coverage Δ
jsdom 48.90% <0.00%> (-0.01%) ⬇️
node 12.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hacke2 hacke2 merged commit 22ea056 into v3.8 Mar 4, 2025
10 checks passed
@hacke2 hacke2 deleted the fix/system-prompt-not-working branch March 4, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants