Updates notes filtering to search description too #5622
+26
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
requested changes
Feb 6, 2025
Added text index to description column to table notes.
Updates notes filtering to search for query text in both note comments and note's description.
nenad-vujicic
force-pushed
the
issue_replace_opening_comment_task_7
branch
from
7db83db to
e8a983a
Compare
Pushed, thanks! Is it safe to have it in same PR or we have to create new PR with migration for adding index? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates notes filtering (querying) to search for query text in both note comments and note's description.
How has this been tested?
Using automated tests before and after migration plus manual tests before and after migration.