Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close directions popup with sidebar #5603

Merged

Conversation

hlfan
Copy link
Contributor

@hlfan hlfan commented Feb 4, 2025

Closes #5599 (literally)

How has this been tested?

Adding a conditional breakpoint in the site.

@AntonKhorev
Copy link
Collaborator

I didn't fix it myself because I was looking for my routing engine test stub code. Added it here.

Copy link
Contributor

@nenad-vujicic nenad-vujicic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great on my side!

@AntonKhorev AntonKhorev force-pushed the close-directions-popup-with-sidebar branch from 46535d6 to 53620c6 Compare February 4, 2025 11:18
@tomhughes
Copy link
Member

Looks good to me, thanks.

@tomhughes tomhughes merged commit 361dcbb into openstreetmap:master Feb 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup in directions is not removed when sidebar is closed
4 participants