Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tactile_paving:colour to moreFields of kerb.json #1365

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dimitar5555
Copy link
Contributor

Description, Motivation & Context

Tactile paving often comes in distinct colours (most often yellow and red). These colours can be used by people with residual vision to know if there is a traffic signal (red paving) or not (yellow paving). Of course this may depend on local legislation, in some countries both colours might be used interchangeably.

This is why I'm putting it in more fields. It's also not easy to survey it from aerials, but it can be surveyed by EveryDoor users (if they get this field from here).

Related issues

None

Links and data

Relevant OSM Wiki links:
No wiki page currently

Relevant tag usage stats:

1654 usages globally, as of 2024-10-22 (https://taginfo.openstreetmap.org/keys/tactile_paving%3Acolour#overview)

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

@Dimitar5555
Copy link
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

image

Search

N/A

Info-i

It should get the value from the item, if I'm not mistaken, https://wiki.openstreetmap.org/wiki/Item:Q22646.

image

Wording

  • American English
  • name, aliases (if present) use Title Case
  • [N/A] terms (if present) use lower case, sorted A-Z

@tordans
Copy link
Collaborator

tordans commented Oct 24, 2024

In general that looks good. But I am not sure if this is a field that we would want all countries to have. In Germany all tactile pavings are white, so this would not be something that I would want to promote to add to the data. This is a "moreFields" field, so we don't really promote it (in iD)…

Does anyone know an easy way to analyse usage per country? In #1201 we have those two query that do something similar, maybe someone can modify them to be used for cases like this?
https://qlever.cs.uni-freiburg.de/osm-planet/ZD2Ojb , https://qlever.cs.uni-freiburg.de/osm-planet/SEaFiO

I have the same question for #1327 to look at country data for the key. It's a bit more pressing there because its a field, not a moreField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants