Stop password managers from autofilling address fields #10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am a 1Password user (and employee). Whenever I am editing a local business's details in iD, I am frustrated that the 1Password browser extension offers to fill out my personal address instead of the business's address. I don't work on our browser extension, I could not tell you why every password manager has their own custom data attribute when autocomplete=off exists. But, for fairness, I am including other major password managers' custom data attributes to stop them as well from autofilling address fields. I was very pleased to find out that there was already a well-used utility function to disable autocomplete/autocorrect/autocapitalize. Fixes openstreetmap#10507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a 1Password user (and employee). Whenever I am editing a local business's details in iD, I am frustrated that the 1Password browser extension offers to fill out my personal address instead of the business's address.
I don't work on our browser extension, I could not tell you why every password manager has their own custom data attribute
when
autocomplete=offexists. But, for fairness, I am including other major password managers' custom data attributes to stop them as well from autofilling address fields:Fixes #10507