Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language data for Sinitic languages #10488

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

winstonsung
Copy link
Contributor

@winstonsung winstonsung commented Oct 9, 2024

Bug: #10488
Bug: openstreetmap/id-tagging-schema#1356
Change-Id: I0ca3cd8b2a82a7edeff70b4be7678e0699214ccc

winstonsung added a commit to winstonsung/openstreetmap-iD that referenced this pull request Oct 9, 2024
Bug: openstreetmap#10488
Change-Id: I0ca3cd8b2a82a7edeff70b4be7678e0699214ccc
Bug: openstreetmap#10488
Change-Id: I0ca3cd8b2a82a7edeff70b4be7678e0699214ccc
@winstonsung winstonsung marked this pull request as ready for review October 9, 2024 14:47
Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good set of changes to me at a glance. Have you verified that the associated name:* tags are well-established, so that we don’t end up promoting tags that the language community is unaware of? Also, we may need to update our copy of wmf-sitematrix so that the Wikipedia field’s language selector and Wikidata field’s label functionality reflects recent changes to Wikimedia’s language list.

@winstonsung
Copy link
Contributor Author

Have you verified that the associated name:* tags are well-established, so that we don’t end up promoting tags that the language community is unaware of?

The language tags were well-established and being used in MediaWiki and on Wikimedia wikis.

  • The variant subtag pehoeji, tailo were supported by the Hokkien community, proposed and added to Language Subtag Registry on 2024-03-04.
  • The variant subtag pinyin was already existed in Language Subtag Registry since 2008-10-14, but not using the standard BCP 47 language tag on OpenStreetMap (so we need to fix it now).

https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry

Also, we may need to update our copy of wmf-sitematrix so that the Wikipedia field’s language selector and Wikidata field’s label functionality reflects recent changes to Wikimedia’s language list.

I'll take a look into it.

@winstonsung winstonsung requested a review from 1ec5 October 9, 2024 15:30
@winstonsung
Copy link
Contributor Author

Also, we may need to update our copy of wmf-sitematrix so that the Wikipedia field’s language selector and Wikidata field’s label functionality reflects recent changes to Wikimedia’s language list.

The list is up-to-date as far as I can see.

Copy link
Collaborator

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language tags were well-established and being used in MediaWiki and on Wikimedia wikis.

I was referring to the OSM database. In theory, the name:* tagging scheme relies on BCP 47, but there have been exceptions in the past, not necessarily the same exceptions as in Wikimedia’s wiki farm. I see that name:zh_pinyin=* has already been mass-replaced with name:zh-Latn-pinyin=*, and name:zh-Latn-pinyin=* is now documented. So that’s good – the momentum is already on the side of the correct code, and iD is just responding to that change. openstreetmap/id-tagging-schema#1356 is another good step.

The list is up-to-date as far as I can see.

It looks like iD is currently using wmf-sitematrix v0.1.x, which means it’ll pull in v0.1.5. We’re overdue for a new release of that package, which will probably be versioned as v0.2.0 due to build system changes, so a small tweak to this code will be necessary once that happens:

'wmf_sitematrix': wmfSitematrixCdnUrl.replace('{version}', '0.1') + 'wikipedia.min.json'

It looks like iD is no longer using wmf-sitematrix for anything that also uses the built-in language data, so we can take care of that change in a separate PR.

@1ec5 1ec5 merged commit 4dcb7f2 into openstreetmap:develop Oct 9, 2024
3 checks passed
@winstonsung winstonsung deleted the dev-10488 branch October 9, 2024 16:38
@1ec5 1ec5 mentioned this pull request Oct 9, 2024
@1ec5
Copy link
Collaborator

1ec5 commented Oct 9, 2024

It looks like iD is no longer using wmf-sitematrix for anything that also uses the built-in language data, so we can take care of that change in a separate PR.

#10489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants