Skip to content

Commit

Permalink
Pin tox to < 4.0.0
Browse files Browse the repository at this point in the history
Tox 4.0.0 was recently released and it has several breaking changes.
We pin to < 4.0.0 here. We are planning to move forward only on the
master charm branches.

Tox is also pinned to < 4.0.0 for stable branches in upstream
openstack-zuul-jobs as well as in zosci-config. However, the
requires= section in the charm's tox.ini file ends up installing
tox>4, wiping out the zuul-pinned tox<4 that was already installed
installed. This patch fixes that.

Related-Bug: #2002788
Change-Id: Ie56b7d8506868db45d116a1fd31db3a24361f149
  • Loading branch information
Corey Bryant committed Jan 20, 2023
1 parent 4275138 commit 96a6dae
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .gitreview
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
host=review.opendev.org
port=29418
project=openstack/charm-ceph-radosgw.git

defaultbranch=stable/quincy.2
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ requires =
pip < 20.3
virtualenv < 20.0
setuptools < 50.0.0
tox < 4.0.0

# NOTE: https://wiki.canonical.com/engineering/OpenStack/InstallLatestToxOnOsci
minversion = 3.18.0
Expand Down

0 comments on commit 96a6dae

Please sign in to comment.