Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug early tox failures #155

Closed
wants to merge 1 commit into from
Closed

Debug early tox failures #155

wants to merge 1 commit into from

Conversation

fnordahl
Copy link
Contributor

@fnordahl fnordahl commented Feb 9, 2022

As recorded in #154 we have an intermittent failure at the very
beginning of a tox run which we don't have any visibility into.

Increase verbosity so that we get a chance to catch what's going
on.

As recorded in #154 we have an intermittent failure at the very
beginning of a tox run which we don't have any visibility into.

Increase verbosity so that we get a chance to catch what's going
on.
@fnordahl fnordahl marked this pull request as draft February 9, 2022 16:36
@fnordahl
Copy link
Contributor Author

fnordahl commented Feb 9, 2022

Converting to draft as I do not know how this would interfere with the fact that we use tox_extra_args to pass in posargs to the func-target env.

Copy link
Contributor

@wolsen wolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this cause problems with future functional tests which also pass arguments such as focal-xena to indicate which test to run?

@ChrisMacNaughton
Copy link
Contributor

I suspect that this change would be "safe", in that it wouldn't break the existing tests; however, I also am fairly sure that it wouldn't have any effect because the latter job overwrites the tox_extra_args value

@fnordahl
Copy link
Contributor Author

I suspect that this change would be "safe", in that it wouldn't break the existing tests; however, I also am fairly sure that it wouldn't have any effect because the latter job overwrites the tox_extra_args value

@ChrisMacNaughton Right, so a descendant job overwrites parent variables. Do you know where the Emit tox command job is defined, and could that be a place to inject the arguments in the right order without messing with the other arguments?

@ChrisMacNaughton
Copy link
Contributor

The whole tox command comes from zuul-jobs

@fnordahl
Copy link
Contributor Author

Can it be overridden?

@ajkavanagh
Copy link
Contributor

Can it be overridden?

Yup, all the bits can be overridden; you just mention them in the job. I think the issue is that a job like "focal-ussuri" will override anything you put in the base func-target job in zuul-config. You can create a job in the charm's osci.yaml directly (and remove the other jobs) as a test, with as much extra detail as you want. Which charm/review/job, and I can help out by updating the review.

@fnordahl
Copy link
Contributor Author

Thanks Alex, trying it out in the per charm job file is a good idea. I'll pop a - name: Emit tox command into one and see what happens.

@fnordahl fnordahl closed this Sep 22, 2022
@fnordahl fnordahl deleted the debug-failing-tox branch September 22, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants