Don't test nrpe bits on rabbitmq-server. (#793) #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkavanagh
force-pushed
the
no-nrpe-on-rabbitmq-tests
branch
from
804ac35 to
a2d856d
Compare
ajkavanagh
force-pushed
the
no-nrpe-on-rabbitmq-tests
branch
9 times, most recently
from
6985c3f to
b32480b
Compare
When the nrpe application is not deployed in the model skip the test that checks for the correct configuration of the nagios checks, this is because at the moment nrpe has no support for jammy, hence is not being deployed in the jammy-yoga bundles. Jammy support for nrpe is tracked at http://pad.lv/1968008 Also patch tox.ini and fix a test to allow the tests to pass.
ajkavanagh
force-pushed
the
no-nrpe-on-rabbitmq-tests
branch
from
b32480b to
971bf80
Compare
|
Hi Alex, is this change still needed? |
coreycb
added
the
stale
I still think the skip is useful; I'll merge the updates into it and sort the conflicts. |
|
After the merge, it appears the main functionality has already made it to stable/yoga. Therefore, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the nrpe application is not deployed in the model skip the test that checks for the correct configuration of the nagios checks, this is because at the moment nrpe has no support for jammy, hence is not being deployed in the jammy-yoga bundles.
Jammy support for nrpe is tracked at http://pad.lv/1968008
(cherry-picked from master at 5a125a4)