COS integration testing: improve COS model lookup #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshBhatthere
approved these changes
Aug 28, 2024
| await ctrl.disconnect() | ||
| if not cos_models: | ||
| return | ||
| return f"{k8s[0]}:{cos_models[0]}" |
There was a problem hiding this comment.
NIT: given that this method is supposed to only give 1 cos model (line 40), does it make sense to have a static key ?
There was a problem hiding this comment.
The reason why I didn't hardcode a static controller/model name is to give some flexibility for the test env. This way you could run the COS model in the same controller, or in another kubernetes controller and would also have some flexibility in naming
There was a problem hiding this comment.
@UtkarshBhatthere does this answer your question? Happy to discuss more if not
lmlg
reviewed
Aug 28, 2024
Also, raise an error instead of skipping the test if no COS model found
sabaini
force-pushed
the
cos-integration-controller
branch
from
2efc894 to
f1b1c3a
Compare
lmlg
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, raise an error instead of skipping the test if no COS model found