[antelope] Enable SSL support on manila client #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python-manilaclient requires passing the cacert file for TLS endpoints. This commit enables that on the `get_manila_session_client` and also, for the manila tests, wraps the client in a retrier that retries on connection failures (i.e. if the server is not running). (cherry picked from commit 42afc47)
ajkavanagh
requested review from
wolsen,
freyes and
dosaboy
and removed request for
wolsen
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Oct 15, 2024
When manila-ganesha is related to vault it needs a client cert to configure the keystone-auth section of manila.conf to communicate with keystone. This patch sets that up and removes the broken server cert auto configuration which ended up masking the manila-share service. func-test-pr: openstack-charmers/zaza-openstack-tests#1250 Change-Id: I55e9aa09b88684517d4052dc56eed0cab05a0262 Closes-Bug: #2064487 (cherry picked from commit ddba2d8) (cherry picked from commit 47be19b260f2434debf57779e5f9110be4afcee1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python-manilaclient requires passing the cacert file for TLS
endpoints. This commit enables that on the
get_manila_session_clientand also, for the manila tests, wraps the client in a retrier that
retries on connection failures (i.e. if the server is not running).
(cherry picked from commit 42afc47)