Add audit middleware test class for ironic-api #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freyes
requested changes
Jun 19, 2024
freyes
requested changes
Jun 19, 2024
There was a problem hiding this comment.
Since you will need to backport this PR in the future, it's better if you squash these two commits.
Ref: https://gist.github.com/lpranam/4ae996b0a4bc37448dc80356efbca7fa
https://review.opendev.org/c/openstack/charm-ironic-api/+/922144 The CI is currently being hung up on the jammy-caracal build with ironic-api but passes the jammy-bobcat build. |
Added general class for testing keystone audit middleware
functionality in charms. Tests correct rendering of
api-paste.ini file. Includes class that skips tests for
charms that do not use an api-paste.ini file.
Example usage with charm Heat:
tests/tests.yaml
tests:
- zaza.openstack.charm_tests.audit.tests.KeystoneAuditMiddlewareTest
tests_options:
audit-middleware:
service: heat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test class for extension of Keystone Audit Middleware tests for charm Ironic-API. This extension is required because Ironic-API does not use an api-paste.ini file and the existing tests are not relevant.