Make Ceph tests self-contained. #1177
Conversation
This PR implements the needed changes so that the Ceph charms can be run without a full Openstack environment. In particular, the RBD mirror charm needed tweaking so as to not depend on Cinder, using pools of its own creating.
| zaza.model.get_application(cls.cinder_ceph_app_name) | ||
| cls.with_cinder = True |
There was a problem hiding this comment.
This is caching whether the cinder-ceph application is deployed in the model at the beginning of the tests. As caching is one of the hard problems, perhaps what's really needed is a predicate function that can be called at each test.
e.g. if some future test decided to test what happens when cinder-ceph is removed from the model (I don't why!) then this caching would break. I think we should all develop more a mindset around avoiding caching where possible unless it really is a performance or memory issue.
There was a problem hiding this comment.
I understand where you're coming from. In the context of this PR, this caching is only looked at the beginning of a couple of tests to skip them in an application is not present. It's pretty harmless in my opinion, but I can accommodate further changes. For example, I can document how it's supposed to be used or replace the caching for a call that looks for the application on the model on each run. What do you think?
There was a problem hiding this comment.
Yes, I think documenting it in the code would provide enough sign-posting if you want to keep the cached value; however, if you can avoid caching altogether then it would make the code more robust from a maintenance perspective. If there are performance issues, or other undesirable side-effects, then caching is acceptable.
There was a problem hiding this comment.
Done, there's no longer caching.
This PR implements the needed changes so that the Ceph charms can be run without a full Openstack environment. In particular, the RBD mirror charm needed tweaking so as to not depend on Cinder, using pools of its own creating, and skipping some tests when needed.